openinference icon indicating copy to clipboard operation
openinference copied to clipboard

Correct span_kind casing.

Open nathanhammond opened this issue 1 year ago • 2 comments

This casing does not agree with the OpenInference spec, or the enum from Python.

References:

https://github.com/Arize-ai/openinference/blob/main/spec/semantic_conventions.md?plain=1#L43

https://github.com/Arize-ai/openinference/blob/main/python/openinference-semantic-conventions/src/openinference/semconv/trace/init.py#L233-L241

nathanhammond avatar May 20 '24 01:05 nathanhammond

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar May 20 '24 01:05 github-actions[bot]

@nathanhammond Thanks for the PR. Can you please sign the CLA by following the instructions from the CLA Assistant above?

RogerHYang avatar May 20 '24 19:05 RogerHYang

Not a copyrightable change (below the threshold of originality as a mechanical change) but if necessary you are encouraged to recreate this.

nathanhammond avatar May 21 '24 07:05 nathanhammond