Arihant Pal comments

Results 28 comments of


                                            Arihant Pal

mcc encoder improperly handles cdp sequence numbers

> > So are you working on it or waiting for approval ? > > no, I noticed it while working on the [new mcc muxer in ffmpeg](https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20024) and looking...

[MM-58498] In Edit history view clicking on chevron doesn't expand or collapse row

/check-cla

[MM-58498] In Edit history view clicking on chevron doesn't expand or collapse row

Hi @marianunez, can you review this for me please? Thanks in advance!

[MM-58498] In Edit history view clicking on chevron doesn't expand or collapse row

Hi @marianunez It can be inconvenient for users trying to copy text within the container, as accidental clicks might collapse it. Additionally, requiring users to find and click the chevron...

[MM-58498] In Edit history view clicking on chevron doesn't expand or collapse row

@matthewbirtch Thankss, Made the changes you suggested, attached a video demo. Let me know what you think! https://github.com/mattermost/mattermost/assets/69034460/ccf33fa2-5079-48a3-8c95-2d61fb76f890

[MM-58498] In Edit history view clicking on chevron doesn't expand or collapse row

Hi @hmhealey and @matthewbirtch, Thanks for your help! I've made the suggested changes and attached a video. Could you please take a look and let me know your thoughts? https://github.com/mattermost/mattermost/assets/69034460/64c2cf81-324e-4188-ab71-655a4d7554fd

[MM-58498] In Edit history view clicking on chevron doesn't expand or collapse row

@hmhealey, I've made some changes that should resolve the type checker issue, but I'm encountering difficulties with the test and snapshot files. Do you have any suggestions?

fix: MCC encoder 16-bit sequence

@canihavesomecoffee can i get a review, Thnxx