node-red-contrib-ocpp icon indicating copy to clipboard operation
node-red-contrib-ocpp copied to clipboard

CP Client JSON node "Delay connection on startup" setting is misleading/incorrectly implemented

Open nagisa opened this issue 1 year ago • 0 comments
trafficstars

When "Delay connection on startup" is NOT checked, the node will not attempt to auto-connect at all. If it IS checked, then the node will auto-connect.

https://github.com/Argonne-National-Laboratory/node-red-contrib-ocpp/blob/f42d4c5a2793105cf807906556186dd67282efd2/ocpp/ocpp-cp-json.js#L52

However, even if the implementation is adjusted to follow the documentation, which describes the operation in reverse:

https://github.com/Argonne-National-Laboratory/node-red-contrib-ocpp/blob/f42d4c5a2793105cf807906556186dd67282efd2/ocpp/ocpp-cp-json.html#L161

the option name is somewhat confusing (in that it suggests that the checkbox controls some delay, rather than the auto-connection itself.)

I would recommend to rename that option to "Auto-connect on node startup".

nagisa avatar Jul 21 '24 20:07 nagisa