electron-release-server icon indicating copy to clipboard operation
electron-release-server copied to clipboard

NSIS updates for a specific flavor

Open MatthieuLeMee opened this issue 3 years ago • 2 comments

How can we get NSIS updates for a specific flavor ? I'm trying to setup feed URL to "http://localhost:1338/update/flavor/flavor1/win64/" but i can't get it working.

I'm successful at getting updates for "http://localhost:1338/update/win64/" but i need to split updates with flavors.

How is this possible without specifying version or channel ? Are some update APIs missing ?

MatthieuLeMee avatar Aug 20 '21 17:08 MatthieuLeMee

Hello! I am the person that created NSIS updates a while ago and I quickly looked into this issue (in my free time). I think I have solved the issue. You can find a branch with a possible fix here: https://github.com/JJ-8/electron-release-server/tree/nsis-updates-specific-flavor-%23285

The specific URL that is now working locally for me is: http://localhost:5000/update/flavor/default/win64/latest.yml so you probably want to use http://localhost:5000/update/flavor/default/win64/ as your feed URL (with a different flavor).

Other similar URLs defined that should work now:

  'GET /update/flavor/:flavor/:platform/latest.yml': 'VersionController.electronUpdaterWin',
  'GET /update/flavor/:flavor/:platform/:channel.yml': 'VersionController.electronUpdaterWin',
  'GET /update/flavor/:flavor/:platform/:channel/latest.yml': 'VersionController.electronUpdaterWin',
  'GET /update/flavor/:flavor/:platform/latest-mac.yml': 'VersionController.electronUpdaterMac',
  'GET /update/flavor/:flavor/:platform/:channel-mac.yml': 'VersionController.electronUpdaterMac',
  'GET /update/flavor/:flavor/:platform/:channel/latest-mac.yml': 'VersionController.electronUpdaterMac',

Can you test it for me? If it fixes the issue, I'll create a PR.

JJ-8 avatar Nov 06 '21 11:11 JJ-8

I have the same question

linglq avatar Dec 28 '21 15:12 linglq