electron-release-server icon indicating copy to clipboard operation
electron-release-server copied to clipboard

show that a release is available for linux when an .AppImage asset exists

Open rgl opened this issue 9 years ago • 15 comments

with a published .AppImage asset the ERS Web UI should show an available release for linux

rgl avatar Dec 17 '16 18:12 rgl

Only .deb, .tar.gz files are currently supported for Linux with poor handling of various OS flavors (all linux distros are treated as one with the only variation being between x86 and amd64).

How would you suggest that they are differentiated?

ArekSredzki avatar Dec 17 '16 18:12 ArekSredzki

Also, I can't dedicate the time to add this myself, but would gladly review any PRs send my way :)

ArekSredzki avatar Dec 17 '16 18:12 ArekSredzki

in theory an .AppImage should run on any linux flavour

rgl avatar Dec 17 '16 18:12 rgl

Great, I more so meant in regards to .deb and the other flavour-specific package types.

ArekSredzki avatar Dec 17 '16 19:12 ArekSredzki

How about having some ordered preference list? that is, if an .AppImage asset is available, show that one? Otherwise, show all the other available versions?

Have you looked at how the Visual Studio Code site does it at https://code.visualstudio.com/Download? That is, just let the user choose?

rgl avatar Dec 17 '16 19:12 rgl

👍

ArekSredzki avatar Dec 17 '16 20:12 ArekSredzki

Replacing all occurrences of .deb with .AppImage did the trick for me.

On the documentation its said that it supports .tar.gz, is that on the same place as where .deb is supported? That is, the filetypes object inside data-service.js?

rgl avatar Dec 18 '16 09:12 rgl

That's the basic idea.

Super busy, will do this properly on Tuesday. Ping me if I don't.

ArekSredzki avatar Dec 18 '16 17:12 ArekSredzki

Hi, was this issue fixed?

tarjei avatar Mar 30 '17 11:03 tarjei

@tarjei I've done 90% of the work for this, but haven't been able to put in the time to wrap it up. might be able to next week

ArekSredzki avatar Mar 30 '17 15:03 ArekSredzki

Cool! Do you have a branch ? tor. 30. mar. 2017 kl. 17.43 skrev Arek Sredzki [email protected]:

@tarjei https://github.com/tarjei I've done 90% of the work for this, but haven't been able to put in the time to wrap it up. might be able to next week

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ArekSredzki/electron-release-server/issues/107#issuecomment-290452070, or mute the thread https://github.com/notifications/unsubscribe-auth/AAM5P5l4Y5pB5KQwkjyicGj4OhLiPJ9-ks5rq82dgaJpZM4LP9FH .

--


Tarjei Huse Mobil: 920 63 413

tarjei avatar Mar 30 '17 16:03 tarjei

Locally 😛 I'll clean up whatever I have and push something to a branch tonight in case you want to take it the last mile :)

ArekSredzki avatar Mar 30 '17 17:03 ArekSredzki

Sadly this will have to wait for the weekend :'(

ArekSredzki avatar Mar 31 '17 04:03 ArekSredzki

I've just run into this too. @ArekSredzki I'm happy to spend some time on the branch tidying it up if you can push it.

achingbrain avatar Sep 11 '17 09:09 achingbrain

Is this feature still open? According the electron-builder docs, AppImages is a suitable target for auto-update

janteque avatar May 09 '19 18:05 janteque