MissionPlanner icon indicating copy to clipboard operation
MissionPlanner copied to clipboard

Camera Gimbal: remove Control Angles

Open rmackay9 opened this issue 2 years ago • 6 comments

As mentioned on the flight code wiki page there's no point in updating the "Control Angles" section of the Camera Gimbal page so we should just remove this section from the page. image

rmackay9 avatar Mar 14 '22 11:03 rmackay9

What if you want to test the gimbal response by specifying exact angles? I use this type of feature in my GCS all the time since I want to be able to programmatically control the angles of the gimbal.

rrr6399 avatar Mar 14 '22 20:03 rrr6399

@rrr6399,

I don't think that the "Control Angles" fields will actually allow moving the gimbal to a specific angle. I've had a peek back at the ArduPilot code history and it looks like we removed these parameters 7 years ago (!) so there should be no danger in removing this section.

rmackay9 avatar Mar 14 '22 23:03 rmackay9

I haven't had the "pleasure" of trying to set up a gimbal yet, but I have one waiting my attention. Being able to test it to nominated angles sounds like a very, very useful thing in the set up and testing phase. Rather than remove this option, if the parameters were removed 7 years ago, what about re-instating the parameters so that it does work ? Thanks

jagrandle avatar Mar 15 '22 00:03 jagrandle

@jagrandle,

I agree that it would be convenient to have a place on this page where users can manually control the gimbal. That shouldn't be done by setting parameters though, instead the DO_MOUNT_CONTROL mavlink message should be used and the flight code already supports this (so just a MP change is required)

For now though, I think expanding the scope will just mean that the suggested change (to remove the fields) won't get done and we will be left with unnecessary fields in the user interface that add confusion.

rmackay9 avatar Mar 15 '22 00:03 rmackay9

Agreed, they are not parameters to be set and forget like the others on this page. More of a testing page sort of thing, like a Motor Test or similar.

jagrandle avatar Mar 15 '22 00:03 jagrandle

OK. I just assumed it was sending do_mount_control messages for testing purposes. Couldn't the current controls just be wired to send do_mount_control instead of sending the old parameters? It might be more convenient to have this simple test interface as you're configuring the gimbal.

rrr6399 avatar Mar 15 '22 04:03 rrr6399

this has been done now so closing.

rmackay9 avatar Jan 30 '23 05:01 rmackay9