Valv-Android
Valv-Android copied to clipboard
[FEATURE REQUEST] - Accept all file types
Is your feature request related to a problem? Please describe. Currently only specific file types are allowed to be encrypted. This is determined by their file name extension. I don't see any reason for that. File types should be determined by their contents, instead of their names. Even if they are unsupported they should still be encryptable. Support for audio only files (mp3, aac. etc.) for example is trivial via the video viewer.
Describe the solution you'd like All files should be encryptable. Files with unknown extensions should trigger a prompt on how to open them (Image, Video, Text, etc.) All other files should also have the opportunity to be opened in the other modes.
Additional context
Every other filesystem/application does it that way, you can rename an image to image.pdf and still open it with an image viewer.
The app imports by mime type, not by extension: https://github.com/Arctosoft/Valv-Android/blob/e4aafe8fe21b85e21a4e7045c537741fdb41f28f/app/src/main/java/se/arctosoft/vault/DirectoryFragment.java#L219
I guess I can add a way to import other file types as well, but then it would not only be a gallery app.
Ah, that makes more sense, I was going off of this file: https://github.com/Arctosoft/Valv-Android/blob/e4aafe8fe21b85e21a4e7045c537741fdb41f28f/app/src/main/java/se/arctosoft/vault/data/FileType.java#L25-L72
Seems like text support is already implemented? But importing is still limited to "image/*", "video/*" mime-types.
https://github.com/Arctosoft/Valv-Android/blob/e4aafe8fe21b85e21a4e7045c537741fdb41f28f/app/src/main/java/se/arctosoft/vault/encryption/Encryption.java#L103-L115
A more separate approach where, everything can be imported and encrypted, and certain files can then be opened/viewed in the vault, would make more sense to me. (I'm also just a user and haven't looked at the code much) But if the scope is just a gallery, then that's certainly understandable.
@1bacon
please keep in mind: One BIG, BIG , BIG advantage of Valv is, that the viewers are integrated in the app. Unencrypted data is (depending on settings) hold in RAM only and never handed out to any external app.
It is a valet for gallery content and not only a cryptic program for files. To hold the actual level of privacy, you would need a content specific viewer for all kind of file types.
You may check out Anemo or DroidFS (F-Droid). It may be what you are searching for.