X2Go #883 - Window Decorations gone when resuming on smaller screen

[mikedep333]

I have been unable to reproduce this bug with a standard X client, but X2Go Client (nxproxy.exe) is affected by this bug:

Window Decorations gone when resuming on smaller screen http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=883

As listed in the Google Spreadsheet, upstream VcXsrv is not affected, but these builds are.

[mikedep333]

I created branch bugfix/bug3 with winmultiwindow.patch reverted. It fixes the issue. However, I need to develop a real fix that fixes the issue that winmultinwindow.patch fixed (X2Go bug 594), without causing this issue.

I also have an email from Alex on 2014-09-02 with more details on winmultiwindow.patch. Here it is:

Hi Mike,

to make a fullscreen window on multimonitor clients, x2goclient changing
a window flags from proxy window (makes window borderless and without
title) and maximize it to display geometry. In one special case, on
secondary monitor left from primary monitor (negative coordinates)
vcxsrv reset the window flags to border window with title and make a
window larger than a screen.

I have found that this happens in function
ConfigureWindow:vcxsrv-code/xorg-server/dix/window.c

called from
winAdjustXWindow:vcxsrv-2010/vcxsrv-code/xorg-server/hw/xwin/winmultiwindow.c

I didn't found a bug itself but was able to creat a workaround, which
makes x2goclient to work properly. See the patch in attachment.

regards,
Alex