Integrate shellcheck to the CI

[mjtrangoni]

Hi,

We should integrate shellcheck to the CI. See,

$ shellcheck --version
ShellCheck - shell script analysis tool
version: 0.6.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
$ shellcheck *.sh | grep line | wc -l
35
For more information:
  https://www.shellcheck.net/wiki/SC2045 -- Iterating over ls output is fragi...
  https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y...
  https://www.shellcheck.net/wiki/SC2010 -- Don't use ls | grep. Use a glob o...

I would propose using CircleCI for this topic, as there is an official docker image for this tool. See here.

If you agree, I could send a PR on this. Note that with CircleCI we could also run things like pylint or windows builds!

[uli42]

I'd say this makes sense for x2go but not for nx-libs. AFAICS we have some shell code for the build but not in the resulting packages.

Mario Trangoni [email protected] schrieb am So., 25. Aug. 2019, 17:27:

Hi,

We should integrate shellcheck https://www.shellcheck.net/ to the CI. See,

$ shellcheck --version ShellCheck - shell script analysis tool version: 0.6.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net $ shellcheck *.sh | grep line | wc -l 35 For more information: https://www.shellcheck.net/wiki/SC2045 -- Iterating over ls output is fragi... https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y... https://www.shellcheck.net/wiki/SC2010 -- Don't use ls | grep. Use a glob o...

I would propose using CircleCI for this topic, as there is an official docker image for this tool. See here https://hub.docker.com/r/koalaman/shellcheck/.

If you agree, I could send a PR on this. Note that with CircleCI we could also run things like pylint or windows builds!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ArcticaProject/nx-libs/issues/839?email_source=notifications&email_token=ABQHBZBKOW3XRN2YQJALVCDQGKJEHA5CNFSM4IPJG2E2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHHR6FQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQHBZHDO7J7OLBNTJ2ROYLQGKJEHANCNFSM4IPJG2EQ .

[mjtrangoni]

@uli42 it costs nothing to run it, and I already fixed all problems. Do you still think the same?

@sunweaver you can close this after merging #1001 and #974

[uli42]

no, it's ok ;-)

On Tue, Feb 9, 2021 at 7:02 PM Mario Trangoni [email protected] wrote:

@uli42 https://github.com/uli42 it costs nothing to run it, and I already fixed all problems. Do you still think the same?

@sunweaver https://github.com/sunweaver you can close this after merging #1001 https://github.com/ArcticaProject/nx-libs/pull/1001 and #974 https://github.com/ArcticaProject/nx-libs/pull/974

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ArcticaProject/nx-libs/issues/839#issuecomment-776128744, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQHBZEXFELFQKPE55XUBI3S6F2CFANCNFSM4IPJG2EQ .