nx-libs icon indicating copy to clipboard operation
nx-libs copied to clipboard

hardcoded path in nxcomp

Open uli42 opened this issue 7 years ago • 2 comments

From nxcomp/Loop.cpp:

    const char *systemEnv = getenv("NX_SYSTEM");

    if (systemEnv == NULL || *systemEnv == '\0')
    {
      nxinfo << "Loop: WARNING! No environment for NX_SYSTEM.\n"
             << std::flush;

      systemEnv = "/usr/NX";
    }

and from nxcomp/Misc.cpp:

  NX_SYSTEM    The directory where NX programs and libraries reside.\n\
               If not set, the value is assumed to be '/usr/NX'.\n\
               Programs, libraries and data files are respectedly\n\
               searched in the 'bin', 'lib' and 'share' subdirecto-\n\
               ries.\n\

-> we should replace the hardcoded path during compilation.

uli42 avatar Nov 27 '17 21:11 uli42

@uli42: don't we have to live with this as legacy?

sunweaver avatar Feb 21 '18 23:02 sunweaver

Yes, but we should move the path to a #define instead of hiding it in the code.

uli42 avatar Jan 18 '20 10:01 uli42