nx-libs icon indicating copy to clipboard operation
nx-libs copied to clipboard

Pr/maximum size

Open uli42 opened this issue 7 years ago • 13 comments

Set the limit for maximum screen size to 32767x32767

Please test if this works with your favourite window manager.

uli42 avatar Jul 03 '17 22:07 uli42

For clarification about what this patch addresses: I normally connect from different clients to my long-running session. Some clients have two monitors, some have one, and also the resolutions differ. As long as the initial session start happened on the client with the biggest resolution I have no problems. But if I happen to start (not reconnect!) the session from a "smaller" client that client's resolution is the value that shows up in xrandr. Reconnecting from a "bigger" client leaves me with a session that is not extendable to the full resolution. As I am using fullscreen sessions this leaves me with some black bars of unusable screen estate with no way to do something against it.

uli42 avatar Jul 10 '17 09:07 uli42

Please review once again

uli42 avatar Jul 12 '17 12:07 uli42

On Mi 12 Jul 2017 21:23:44 CEST, Ulrich Sibiller wrote:

uli42 commented on this pull request.

int h[] = {0, 240, 360, 480, 480, 600, 600, 768, 864, 720,
800, 1024, 768,

  •              900,  900, 1200, 1050, 1080, 1200, 0, 0};
    
  •  900,  900, 1200, 1050, 1080, 1200, 32767, 0, 0};
    

MAXSHORT ist better, agreed. We can add some more resolutions but
with the new maximum size you can add any resolution on your own.

Yep.

However: As long as rrxinerama is active your won't ever see those
resolutions.

Ok, then leave it as is (except using MAXSHORT) and update your PR branch.

Mike

DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: [email protected], http://das-netzwerkteam.de

sunweaver avatar Jul 12 '17 19:07 sunweaver

@uli42: please rebase against latest 3.6.x branch, so I can merge.

sunweaver avatar Jul 12 '17 21:07 sunweaver

@uli42: What is the status of #475? I already approved the merge, but you added more commits without comment. Was that by accident? It feels that some of the newer commits should be part of a second PR.

Please give feedback on your intention for this PR. Thanks!

sunweaver avatar Aug 22 '17 17:08 sunweaver

To answer your question: no, those commits where not by accident, I simply noticed that we need them in the -rrxinerama case.

This patch is working but kind of worthless. It revealed a general problem: with rrxinerama activated (which is the default) modifying screens via xrandr is not really working well due to the fact the the xinerama code will throw away what the user specified on the next move or resize of the nx window. I have not yet come up with a proper idea how to handle that. You can, however, use this code together -rrxinerama.

uli42 avatar Aug 30 '17 19:08 uli42

@Ionic: can you take a second look at that (with my look being the first). I've stumbled over this quite often when switching sessions between machines. Esp. when switching to machines with 4k displays, the size limitation of the previous host is nasty. I'd love to get this changeset in.

sunweaver avatar Jul 22 '18 14:07 sunweaver

sunweaver: so you saw this limitation even with active rrxinerama?

uli42 avatar Jul 23 '18 17:07 uli42

@uli42: @Ionic: we should get this PR merged over the weekend, IMHO.

sunweaver avatar Nov 09 '18 15:11 sunweaver

@uli42: @Ionic: this PR #475 has become quite stale but is still an issue in real life cases. I am inclined to rebase and merge it. Thoughts? Vetos?

sunweaver avatar Aug 27 '19 06:08 sunweaver

What about this one? The maximum size issue is some sort of a problem, indeed. I was about to rebase it, but then spotted the top commit on this branch. Please cleanup (and rebase).

sunweaver avatar Jan 05 '20 22:01 sunweaver

must check - but not today

On Sun, Jan 5, 2020 at 11:28 PM Mike Gabriel [email protected] wrote:

What about this one? The maximum size issue is some sort of a problem, indeed. I was about to rebase it, but then spotted the top commit on this branch. Please cleanup (and rebase).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ArcticaProject/nx-libs/pull/475?email_source=notifications&email_token=ABQHBZCCBRORLJM57SK52FDQ4JNJZA5CNFSM4DRS6DC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIEBFNI#issuecomment-570954421, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQHBZAP3I2YBK4YK57NMQ3Q4JNJZANCNFSM4DRS6DCQ .

uli42 avatar Jan 05 '20 22:01 uli42

must check - but not today

Gentle reminder...

sunweaver avatar Oct 17 '20 20:10 sunweaver