grab-site icon indicating copy to clipboard operation
grab-site copied to clipboard

Python 3.8 deprecation

Open jacob-willden opened this issue 8 months ago • 6 comments

The installation instructions for MacOS state to install Python 3.8, but Python 3.8 officially reached its end of life on October 7, 2024 and is disabled in Homebrew. Has grab-site been tested with Python 3.9 or newer yet?

jacob-willden avatar Apr 13 '25 03:04 jacob-willden

google-re2 now requires Python 3.9 (as of a few weeks ago: https://github.com/google/re2/issues/559). This causes grab-site to fail being installed on 3.8. We will have to switch to 3.9 as soon as possible to fix this issue.

exurd avatar Aug 19 '25 03:08 exurd

We will have to switch to 3.9 as soon as possible to fix this issue.

Actually, scratch that; Python 3.9 is going to be EOL this October... Upgrading this program to use 3.11+ would be the best move here.

exurd avatar Aug 19 '25 05:08 exurd

The best thing you can do for the time being is probably use python 3.8 from a container, e.g., using https://github.com/Nold360/docker-grab-site . I'm trying to update to 3.13, but it's turning into a "give a mouse a cookie" / onion-peeling scenario.

ngie-eign avatar Sep 05 '25 01:09 ngie-eign

While that Docker image does work, it was last updated 5 years ago; it uses grab-site 2.1.18 (and Python 3.7!). It also cannot be built from the Dockerfile (the same re2 issue as above).

exurd avatar Sep 05 '25 01:09 exurd

Issue opened for updating ludios_wpull: https://github.com/ArchiveTeam/ludios_wpull/pull/36 . Once that change is merged I'll open up the PR to update the software pins (it seems to just work out of the box).

ngie-eign avatar Sep 05 '25 02:09 ngie-eign

Here's my PR to update the software pins to versions that support python 3.13: https://github.com/ArchiveTeam/grab-site/pull/249 . It seems to work so far, but I've been doing mostly happy path testing and haven't looked too deep at the code to make sure that everything is functioning properly.

ngie-eign avatar Sep 05 '25 03:09 ngie-eign