Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

Alttp: assert failures in fill_restrictive

Open black-sliver opened this issue 3 years ago • 0 comments
trafficstars

The following locations (maybe more) have rules that depend on state:

  • Turtle Rock - Big Key Chest
  • Palace of Darkness - Harmless Hellway
  • Palace of Darkness - Big Key Chest
  • GT - Map Chest iirc

When filling in fill_restrictive we check with maximum_exploration_state but in push_item we assert with self.state, which seems to be different and fail the assertion. This accounts for quite a few generation failures in my random-yaml testing, so this should probably be fixed. Ping me on discord if you need a reproducer, but I'm pretty sure the difference in state is what makes it crash.

black-sliver avatar Aug 16 '22 21:08 black-sliver