Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

Published 20 hours ago • verified publisher icon ArchipelagoMW

core: rip out RegionType and rework Region class

Open alwaysintreble opened this issue 2 years ago • 1 comments

Unsure if the special handling in the spoiler class can be fully ripped out so I worked around it for now. Also unhappy with how I handled getting region entrances so maybe this could be changed to a Region method instead of a function in main?

alwaysintreble avatar Jul 23 '22 01:07 alwaysintreble

Went ahead and added a Region class rewrite to this PR,

alwaysintreble avatar Jul 23 '22 17:07 alwaysintreble

@Berserker66 this looks good now. The one big remaining question, besides merge order, is at what point we want to have the world API semi-stable (i.e. implement backwards compat and throw Deprecation Warnings): when we merge this, the APWorlds currently distributed will not work anymore, and when the APWorlds get updated, they won't work with current stable anymore.

black-sliver avatar Feb 12 '23 16:02 black-sliver

@Berserker66 this looks good now. The one big remaining question, besides merge order, is at what point we want to have the world API semi-stable (i.e. implement backwards compat and throw Deprecation Warnings): when we merge this, the APWorlds currently distributed will not work anymore, and when the APWorlds get updated, they won't work with current stable anymore.

Not sure yet. I want to try and find time for the .apworld installer soonish, which could do some version checking in there - and would run unittests so it would bubble up some of these issues.

Berserker66 avatar Feb 13 '23 02:02 Berserker66

image

Berserker66 avatar Feb 13 '23 02:02 Berserker66

oh yeah, might as well ping @espeon65536 as the OoT changes go a bit beyond mere fixing.

Berserker66 avatar Feb 13 '23 02:02 Berserker66