Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

Stardew Valley: Remove some events for a slight performance increase

Open Jouramie opened this issue 3 months ago • 0 comments

What is this fixing or adding?

This PR removes some events that were added to handle indirect connection between the Carpenter shop, Pierre and some buildings (only relevant when building progression is vanilla with entrance randomizer). Since the 5.x.x update, indirect connection are automatically calculated and registered every time a rule is added to an entrance, so those events are unnecessary.

This improves performances for two reasons:

  • The performance overhead for the fill to sweep again every time an event is collected is no longer required since the indirect connection are automatically configured
  • Replacing the rule checking for the event by the actual rule underneath sometime allows simplification.

How was this tested?

  • Added a log to make sure the indirect connection are created

image

  • Rolled 100+ worlds for performance tests. The overall impact on performance is pretty small. It's around 3% faster.

image

If this makes graphical changes, please attach screenshots.

N/A

Jouramie avatar Oct 24 '24 04:10 Jouramie