Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

Cleanup: MMBN3 Typo for SloGauge

Open Hexadigital opened this issue 1 year ago • 5 comments

What is this fixing or adding?

This fixes the Archipelago item name for SloGauge in Mega Man Battle Network 3 which was misspelled as SloGuage, causing the typo to appear in the Archipelago client and in games that display AP item names.

How was this tested?

Not necessary due to the change only being swapping two characters in a single string.

If this makes graphical changes, please attach screenshots.

N/A

Hexadigital avatar Jun 03 '24 21:06 Hexadigital

Sorry, I'm not sure what you're referencing there - would you like the variable name updated as well? I did not alter that in the file I edited.

Hexadigital avatar Jun 04 '24 06:06 Hexadigital

Sorry, I'm not sure what you're referencing there - would you like the variable name updated as well? I did not alter that in the file I edited.

I apologize for not being clear before. But yes, since the string is being corrected, the variable name in both /Names/ItemName.py and Items.py should probably be changed as well since they are both mispelled and the variables try to match the string closely. It's more a consistency thing rather than strictly correct or incorrect. Changing the names or not should not affect generation at all.

nicholassaylor avatar Jun 04 '24 17:06 nicholassaylor

Okay! Those have been adjusted as well.

Hexadigital avatar Jun 05 '24 03:06 Hexadigital

@digiholic Reminder that this exists

Exempt-Medic avatar Sep 18 '24 12:09 Exempt-Medic

Ah, woops. I get so many messages about merges that I never saw this notification amongst them all. I need to clean up my email notifications...

digiholic avatar Oct 23 '24 16:10 digiholic