Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

Wario Land 4: Implement new game

Open lilDavid opened this issue 1 year ago • 1 comments

What is this fixing or adding?

Adds Wario Land 4 as an available game for AP.

How was this tested?

Many playtests and unsupported games over several APworld releases.

If this makes graphical changes, please attach screenshots.

Sapphire Passage screen with some collection 40 Below Fridge, box containing flippers Palm Tree Paradise, Moon Pearl obtained from box Sent Moon Pearl to lil David LttP

lilDavid avatar May 04 '24 18:05 lilDavid

I'll throw in a review later, but for now: be sure to add your game to the Archipelago README.md and to add yourself to the CODEOWNERS file in the Archipelago docs folder

ScipioWright avatar May 06 '24 14:05 ScipioWright

Something else I forgot to mention, you may want to implement a get_filler_item_name function, so that when the multiworld has to ask for items from your world (like with plando or itemlinks) it will only pull from filler items you define instead of all items, including progression ones. Another thing you could consider is adding start_inventory_from_pool support, it's a pretty simple options change and you wouldn't have to rearrange anything to support it (it would also benefit from get_filler_item_name).

Exempt-Medic avatar Aug 21 '24 17:08 Exempt-Medic

Some more comments. One general question I have is why this code is using Sequence and Mapping so much instead of List and Dict?

I like to use Sequence and Mapping because they give more of a hint that the value won't be modified. I use tuples as immutable sequences a lot, and Sequence covers both tuples and lists.

lilDavid avatar Aug 22 '24 15:08 lilDavid