Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

The Witness: Panel Hunt Mode

Open NewSoupVi opened this issue 1 year ago • 4 comments

Solve a specified number of random, visually marked panels in the game.

Features:

  • Victory Condition: Panel Hunt
  • Configurable amount of Total Panel Hunt Panels & Required Percentage
  • Area hints have been adjusted to include that info

System Changes:

  • Changed Event system to allow multiple events for the same entity

Tested: I have played over a dozen seeds myself and we had a playtest. I also looked at spoiler logs and all that.

NewSoupVi avatar May 04 '24 06:05 NewSoupVi

Since #2698 is merged, you should probably update the description to not say "don't review" lmao

agilbert1412 avatar Jun 08 '24 04:06 agilbert1412

Kaito's comment about the function being way too big made a lot of sense to me. The best way I found to address this is to make an entire new class called EntityHuntPicker

Technically there is more text now, but it's mostly in the form of docstrings now, instead of comments

It's a lot of deleted and added lines, but I've only moved stuff around. It's obviously possible that I missed stuff in the process. I'll probably do some more testing

Unit tests would obv be good but I need https://github.com/ArchipelagoMW/Archipelago/pull/3328 first for that

NewSoupVi avatar Jun 09 '24 00:06 NewSoupVi

Drafting this because I want to add unit tests for this.

NewSoupVi avatar Jul 06 '24 13:07 NewSoupVi

Added some unit tests :)

Edit: Ayyy, they even found something.

NewSoupVi avatar Jul 06 '24 17:07 NewSoupVi