Archipelago
Archipelago copied to clipboard
ArchipelagoMW
[The Legend of Zelda] Add Arrow Shuffle
What is this fixing or adding?
This adds the ability to shuffle the Arrow item into the item pool. This ability is controlled by the "Arrow Location" YAML option that has now been added.
How was this tested?
After confirming functionality, I generated YAMLs for 20 games on each setting (other settings set to random). In the 5 of these 20 that I checked the spoiler log, Arrows placed correctly.
I did not attempt to host or connect to a game with these features, but I feel that this is not something that will be impacted by this change.
If this makes graphical changes, please attach screenshots.
I would absolutely recommend testing hosting, connecting, and running a game with these changes, and verifying that picking up the Arrow item anywhere else, and also receiving it as an item from another player both work. It's not advisable to just assume it will work.
What Figment and Pory said. I know there's no client side changes and I personally know there's no issue with arrows being wherever (seeing as how that was how things were originally) but it's always worth triple checking that things ingame are what are claimed to be.
Additionally, I'm not a fan of the option description. IMO The first sentence should always be describing what the option does in brief, with further sentences explaining the details and the specifics of the various options. "Bow requires you to also find an Arrow in order to use it." isn't that, it's a description of the basic rules of TLoZ that anyone coming in to the rando ought to know by virtue of vanilla knowledge. This could lead to the impression that this option somehow affects that basic rule (which it doesn't). I know this seems like a minor thing but good option documentation once saves a hundred questions down the line. FWIW the description of the actual choices is fine: it's just the first line I'm not feeling.
I honestly forgot about this PR. There was some discussion about it in the discord, and @Rooby-Roo requested it be closed (mainly for the fact that it's based on their main branch of their fork). I will close this one, but Rooby, feel free to reopen it on a separate branch (and with any other additions like the start_with option you mentioned) if you want.
