Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

InnoSetup: During setup LTTP sprite download can be inadvertently interrupted during installation.

Open Drexl opened this issue 10 months ago • 4 comments

What happened?

After setup of 0.4.6 you are prompted to restart windows while LTTP sprites are still downloading, potentially interrupting the process.

What were the expected results?

All setup procedures would be completed before being prompted to restart windows.

Software

Local generation

Drexl avatar Apr 23 '24 22:04 Drexl

Interesting. Not much work has been done on the innosetup script in a while, but if no one else does, I'll see if I can take a look when I have the time.

ThePhar avatar Apr 23 '24 22:04 ThePhar

The installer doesn't need you to restart windows and doesn't prompt for it. I just tested it. Whatever prompted you to restart was not the Archipelago installer.

alwaysintreble avatar Apr 23 '24 22:04 alwaysintreble

The installer doesn't need you to restart windows and doesn't prompt for it. I just tested it. Whatever prompted you to restart was not the Archipelago installer.

I presume it's the Visual C++ Redistributable actually. It would also only request a restart if it was the first time installed.

ThePhar avatar Apr 23 '24 22:04 ThePhar

It is visual C++ redist, yes. The way it works is that when a windows component like it is updated or installed a flag is set that will cause all future setups, including ours, to ask for a restart. You can get the same if you run any other windows setup before the shutdown to get the same question.

Berserker66 avatar Apr 23 '24 22:04 Berserker66

This should be fixed as of 0.5.0 since the installer will wait for sprites to finish downloading before continuing to the end of set-up.

nicholassaylor avatar Jun 03 '24 00:06 nicholassaylor