Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

SC2: Fix unused_items refill to respect item dependencies.

Open Ziktofel opened this issue 10 months ago • 4 comments

What is this fixing or adding?

See bug: https://github.com/Ziktofel/Archipelago/issues/187 After main culling process done, some items might be brought back. However, the item dependencies were ignored. This fixes that by filtering unused_items by using dependency rules

How was this tested?

Tested with YAML that produced the issue, the problem is gone now

If this makes graphical changes, please attach screenshots.

No

Ziktofel avatar Apr 08 '24 00:04 Ziktofel

Yeah, the item dependencies could use some refactoring but that's out of scope of this PR

Ziktofel avatar Apr 08 '24 20:04 Ziktofel

Yeah, it's a bugfix, I've straightly fixed that so it can't break anything else

Ziktofel avatar Apr 08 '24 21:04 Ziktofel

Changed back due to @Salzkorn's tests

Ziktofel avatar Apr 08 '24 21:04 Ziktofel

Yeah, I've added a type check to validate that

Ziktofel avatar Apr 08 '24 21:04 Ziktofel

In Intellij it highlights the code if it fails type check

Ziktofel avatar Apr 09 '24 19:04 Ziktofel