Archipelago
Archipelago copied to clipboard
SC2: Fix unused_items refill to respect item dependencies.
What is this fixing or adding?
See bug: https://github.com/Ziktofel/Archipelago/issues/187
After main culling process done, some items might be brought back. However, the item dependencies were ignored. This fixes that by filtering unused_items
by using dependency rules
How was this tested?
Tested with YAML that produced the issue, the problem is gone now
If this makes graphical changes, please attach screenshots.
No
Yeah, the item dependencies could use some refactoring but that's out of scope of this PR
Yeah, it's a bugfix, I've straightly fixed that so it can't break anything else
Changed back due to @Salzkorn's tests
Yeah, I've added a type check to validate that
In Intellij it highlights the code if it fails type check