Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

The Witness: mypy compliance

Open NewSoupVi opened this issue 1 year ago • 1 comments
trafficstars

This PR "affects core" because it is based on this PR: https://github.com/ArchipelagoMW/Archipelago/pull/3107. It will be rebased without those changes after that PR is merged, or at some other point when I want to take this out of draft.

This PR is in response to the mypy PR: https://github.com/ArchipelagoMW/Archipelago/pull/3107

There are two remaining errors I cannot solve without touching core (I believe).

worlds\witness\options.py:3: error: Skipping analyzing "schema": module is installed, but missing library stubs or py.typed marker  [import-untyped]
worlds\witness\hints.py:553: error: Call to untyped function "get_locations" in typed context  [no-untyped-call]

This PR will be drafted for now until the mypy PR is merged / rejected / finalised. Also, it is waiting on https://github.com/ArchipelagoMW/Archipelago/pull/3007 to be merged first, at which point I will do an interactive rebase to have this branch work correctly.

NewSoupVi avatar Apr 07 '24 21:04 NewSoupVi

Update: Probably won't actually add my world to the list of files because the remaining errors are with core and the strategy seems to be "If there's something wrong with core that is stopping you from being mypy compliant, hopefully that'll motivate you to go and add typing to core", which it does not, for me. :D

I'll still try to get this merged because I think it makes the Witness apworld better.

NewSoupVi avatar Apr 08 '24 21:04 NewSoupVi