The Witness: Migrate joke hints to the client

[hatkirby]

trafficstars

What is this fixing or adding?

Joke hints are being moved into the client, so they no longer need to be stored here. This change also nulls out joke hints sent to the client, which is needed for it to know to generate a joke hint locally.

Client PR: NewSoupVi/The-Witness-Randomizer-for-Archipelago#28

How was this tested?

Test generations with and without audio log hints. Game was closed and reopened to ensure consistency.

If this makes graphical changes, please attach screenshots.

[NewSoupVi]

Waiting on client PR: https://github.com/NewSoupVi/The-Witness-Randomizer-for-Archipelago/pull/28

[PoryGone]

Based on the content of the PR, I'm gathering that by "local", you mean "handled client-side"; is that correct?

[hatkirby]

That's correct.

[NewSoupVi]

Moving this to core review because it adds 3 lines

[NewSoupVi]

This PR will likely conflict with https://github.com/ArchipelagoMW/Archipelago/pull/3007, which I absolutely need to be merged before anything else, so I'm putting this one on "waiting on: other".