Archipelago
Archipelago copied to clipboard
ArchipelagoMW
Docs, Starcraft 2: Add French documentation for setup and game page
What is this fixing or adding?
- Add a French version of the setup and game page for Starcraft 2.
- Except for the "Progression Balancing" section, the content of the French setup/game page should be a direct translation of its English counter-part.
- Adapt the Starcraft 2 ?world class? for multiple tutorials.
- Add a link to the French game page in the English game page to make potential French user aware that it exist (Without that, the French game page is only available by changing the url by hand.)
- Corrected the English game page first header (Starcraft 2 is no longer limited to Wing of Liberty) and a sentence.
How was this tested?
By locally hosting the website, the rendering of the French setup and game page was confirmed. It was also confirmed that the English setup and game page remains correctly rendered. All the url and link of the French setup and game page were confirmed to redirect at the correct page/location.
If this makes graphical changes, please attach screenshots.
None that are relevant.
I don't speak French but the French manual appears to have all the sections as the English one does.
Thank you benny-dreamly for the comments! I applied some of them but I would require your input on those kept open.
Thank you @agilbert1412 for the comments! I applied most of them but I would like your input on those kept open.
All the suggestions of agilbert1412 were considered. I left two of them unresolved since they required larger changes that might be of interest to review again. However, agilbert1412 has already indicated that the current version seems acceptable.
Some other changes, that were not requested, were made:
- Changed all Starcraft to StarCraft for uniformity.
- Changed all link to Archipelago own pages to relative link so that it works even when self-hosting.
- I validated all the link after the changes.
- Information about the datapackage was also added in the English part for uniformity with the proposed French documentation.
- [x] Need to add a mention that the mod/game might break if not setted to english
- Added a mention that the mod/game might break if not setted to english
- "Notez que votre jeu StarCraft 2 (...)"
- Added instruction for custom hotkey
- "Mon profil de raccourcis clavier n'est (...)"
- Removed correction of game name in english part since proposed in #3074
I tested locally and can confirm that the relative links work as expected, and that the French documentation is accessible as expected (I still can't read most of the French to comment on that though).
All suggestions were processed. Every part of the French and English modifications were checked at least once. The validity of the links were tested by both the author and a peer.