Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

CI: don't trigger unittests for docs

Open black-sliver opened this issue 11 months ago • 4 comments

What is this fixing or adding?

See title. Also any .md (like README.md and worlds/_bizhawk/README.md) now.

How was this tested?

CI.

black-sliver avatar Mar 14 '24 00:03 black-sliver

Notably, this does not capture the original use case that I brought up in the dev channel, that being README.md and CHANGELOG.md files in the root of world folders.

PoryGone avatar Mar 14 '24 00:03 PoryGone

Updated. Note that the original rule is still useful because it matches *.png and *.jpg in world docs.

black-sliver avatar Mar 14 '24 00:03 black-sliver

Until one day we might have doctests, but for now this should be fine.

Berserker66 avatar Mar 21 '24 15:03 Berserker66

Hm, I mean there is this, that I didn't think about: https://github.com/ArchipelagoMW/Archipelago/blob/main/test/webhost/test_docs.py

black-sliver avatar Mar 21 '24 20:03 black-sliver

I changed it to draft because it breaks the unit test that checks if a world has docs (for webhost).

black-sliver avatar Apr 21 '24 09:04 black-sliver