Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

Core: move rules helpers out of generic

Open alwaysintreble opened this issue 1 year ago • 3 comments

What is this fixing or adding?

Moves the rules helpers out of the generic world and into a worlds level module. Modifies the imports for all affected worlds and leaves a stub for apworld compatibility.

How was this tested?

Unit tests and a handful of generations with effected worlds

If this makes graphical changes, please attach screenshots.

alwaysintreble avatar Mar 05 '24 02:03 alwaysintreble

Change to SoE lgtm, however I am not certain if we want to make this change. I feel like worlds.rules is not a good spot to have this either, and moving it twice sounds horrible. I think if we pick apart the AP core more, it would end up in rules or core.rules or something like that, not in worlds.<anything>.

black-sliver avatar Mar 10 '24 12:03 black-sliver

I feel like worlds.rules is not a good spot to have this either, and moving it twice sounds horrible. I think if we pick apart the AP core more, it would end up in rules or core.rules or something like that, not in worlds.<anything>.

fwiw i agree with this. the reason i put it here was berserker's comment on it https://discord.com/channels/731205301247803413/731214280439103580/1214383024553201685

alwaysintreble avatar Mar 10 '24 16:03 alwaysintreble

I guess @Berserker66 to see if they want this as-is (and fix the doc mistake and resolve conflicts), or if we should close it.

black-sliver avatar Mar 10 '24 17:03 black-sliver