Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

ALTTP: Rename Map/Compass/Big Key Chests and similar to something more informative

Open Kappatechy opened this issue 1 year ago • 4 comments

What is this fixing or adding?

A number of locations in ALTTP have names that are unhelpful in determining where to go within their respective dungeons in order to find those checks. The Big Key Chests in particular often get confused with the Big Chests, causing unnecessary difficulty to new players. This PR renames the Map, Compass, and Big Key Chests, along with a small number of other chests that were named for their vanilla contents, giving them names that better describe where in their respective dungeons they appear.

How was this tested?

I do not know how to run from source, and as such, have not been able to test this. I would recommend generating a few games of ALTTP with various settings (Entrance Shuffle, Inverted) and checking to make sure nothing explodes on any of them. I would also suggest digging into the spoiler logs for such generations to ensure the new chest names, not the old ones, appear there.

Kappatechy avatar Feb 14 '24 21:02 Kappatechy

I do not know how to run from source, and as such, have not been able to test this.

You should follow this guide to get set up with running from source, and do some testing yourself before opening to peer review: https://github.com/ArchipelagoMW/Archipelago/blob/main/docs/running%20from%20source.md

PoryGone avatar Feb 15 '24 19:02 PoryGone

I have now run several tests, with various player settings: Standard/Open/Inverted world state, Key Drop Shuffle on or off, Entrance Shuffle, etc. Everything seems to behave as it should.

Kappatechy avatar Feb 16 '24 01:02 Kappatechy

What is this currently waiting on? And how does one change the labels?

Kappatechy avatar Apr 09 '24 17:04 Kappatechy

What is this currently waiting on? And how does one change the labels?

I would assume these conflicts. image

Also only triage collaborators (or core maintainers) can change labels.

ThePhar avatar Apr 15 '24 03:04 ThePhar