Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

CommonClient: Improve commands

Open EmilyV99 opened this issue 1 year ago • 5 comments

What is this fixing or adding?

Modified some basic CommonClient commands to be more useful. '/missing' now properly can take multi-word filter text (instead of giving an error for invalid param count), and is case-insensitive. '/received', '/items', and '/locations' now also take optional filter text. Feedback from all changed commands also slightly improved (ex. now repeats the filter text used, indicating the results only include those that match that filter; where it previously showed a number of results, that now only counts those that match the filter, instead of all)

MultiServer's '!missing' and '!checked' have also received similar improvements.

How was this tested?

Ran all of the changed commands, checking for expected output. Some examples shown below. Commands were tested both with and without filter text.

If this makes graphical changes, please attach screenshots.

image (/received: Finding the days of the traveling cart in Stardew Valley that have been received was the main driving factor in this addition, and works flawlessly) image (!missing - the MultiServer command) image (!checked - the MultiServer command) image (/missing - the CommonClient command) image (/items) image (/locations)

EmilyV99 avatar Jan 24 '24 20:01 EmilyV99

First one is a duplicate of https://github.com/ArchipelagoMW/Archipelago/pull/2675

Berserker66 avatar Jan 24 '24 23:01 Berserker66

https://github.com/EmilyV99/Archipelago/pull/2

beauxq avatar Feb 21 '24 14:02 beauxq

Did you test to make sure they still work without filter text?

beauxq avatar Feb 21 '24 14:02 beauxq

Did you test to make sure they still work without filter text?

aye, they all work without filter text, and give a different message output (ex. Found x/y missing checks vs Found x/y matching missing checks) based on being filtered or not.

EmilyV99 avatar Feb 22 '24 21:02 EmilyV99

This has conflicts now just so you know

Exempt-Medic avatar Apr 30 '24 21:04 Exempt-Medic