Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

WebHost: Make list options available from the player-options page

Open nex3 opened this issue 1 year ago • 6 comments

With this, players no longer need to go to the weighted options page to set (or even discover) the Item Pool, Item & Location Hints, and Priority & Exclusion Locations options, or any list-based options defined for an individual game.

This also unifies more of the rendering code for player and weighted options, so it'll be easier to share UI for new option types between them in the future.

In a follow-up PR, I intend to make it possible for individual options to specify whether they're visible on both options pages, the weighted-options page only, or only usable from YAML.

How was this tested?

I manually tested loading up several pages, setting options, refreshing to ensure that the options persisted in local storage, and exporting the options as YAML.

If this makes graphical changes, please attach screenshots.

image

nex3 avatar Dec 05 '23 11:12 nex3

Maybe I'm in the minority here, but I think that for most games, this page is already overwhelming to new users, and that this PR makes that significantly worse. I'm of the opinion that start_inventory, priority_locations, and excluded_locations are more advanced settings, that don't need to be immediately exposed in this way. It would be nice to see efforts made to make this page more approachable and useable before we start cramming more junk into it.

PoryGone avatar Dec 05 '23 21:12 PoryGone

Maybe I'm in the minority here, but I think that for most games, this page is already overwhelming to new users, and that this PR makes that significantly worse. I'm of the opinion that start_inventory, priority_locations, and excluded_locations are more advanced settings, that don't need to be immediately exposed in this way. It would be nice to see efforts made to make this page more approachable and useable before we start cramming more junk into it.

It is very underwhelming for experienced users. I would very much like to have the ability to create yamls on the website with all settings and not have to use the weighted settings page, the sliders for which I find very annoying, especially when I'm away from my computer and need to make a yaml on mobile

Alchav avatar Dec 06 '23 02:12 Alchav

Maybe I'm in the minority here, but I think that for most games, this page is already overwhelming to new users, and that this PR makes that significantly worse. I'm of the opinion that start_inventory, priority_locations, and excluded_locations are more advanced settings, that don't need to be immediately exposed in this way. It would be nice to see efforts made to make this page more approachable and useable before we start cramming more junk into it.

It is very underwhelming for experienced users. I would very much like to have the ability to create yamls on the website with all settings and not have to use the weighted settings page, the sliders for which I find very annoying, especially when I'm away from my computer and need to make a yaml on mobile

I get where you're coming from, but power users are significantly less likely to be fully turned off of using the platform when their needs aren't met than new users are, and as such, the user experience of the new user should take precedence when both cannot be simultaneously met.

Regardless, this has already been discussed at length in the Discord server, and Farrak has voice there his own concerns with this PR.

PoryGone avatar Dec 06 '23 04:12 PoryGone

Could it be possible to have the player options page have a tab for basic and advanced?

ReverM avatar Dec 24 '23 20:12 ReverM

If I'm not mistaken, discussion of this took place in the Discord server, and forthcoming work from @LegendaryLinux will make this PR obsolete.

PoryGone avatar Feb 10 '24 21:02 PoryGone

PoryGone is correct. I have an in-progress PR which all but removes JS from player-options and drastically cuts down on the JS in weighted-options.

LegendaryLinux avatar Mar 12 '24 05:03 LegendaryLinux

I'm going to close this PR since it's been obsoleted by #2614.

ThePhar avatar Jun 01 '24 11:06 ThePhar