Archipelago LADX: Implement Collect on checks

What is this fixing or adding?

Adds check collection to LADX, allowing the server to inform of collected checks and then in-game modifying the memory to indicate this, removing items, opening chests, etc.

How was this tested?

I've tried a variety of checks and then loading saves in various states of completion, making sure that local items are not collected to prevent soft locking.

If this makes graphical changes, please attach screenshots.

No graphical changes made.

Jun 27 '23 02:06 AustinSumigray

@zig-for

Jun 27 '23 03:06 ThePhar

This overall looks good. Test it out on a couple of games, but as long as it looks good from the AP side I see nothing wrong. Will try to look again next week to spot any sneakier issues.

Jun 27 '23 03:06 zig-for

I added an optional behavior, and filled out the blacklist. Saw some strange behavior, where if an owl statue is on the same address as a location check, the location check would be collected properly, and the check would not appear in-game (or the chest if it was a chest would appear opened) but the tracker wouldn't correctly say it was collected. If I can find a solution for this (or somebody knows one) it would be good to fix, but 90% of locations beind collected is better than none.

Jun 28 '23 01:06 AustinSumigray

Solved that glitch, so now all the remaining blacklist items have a purpose.

Jun 28 '23 15:06 AustinSumigray

If you didn’t already, worth putting comments why each item is there in the black list Sent from my iPhoneOn Jun 28, 2023, at 8:41 AM, AustinSumigray @.***> wrote: Solved that glitch, so now all the remaining blacklist items have a purpose.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Jun 29 '23 00:06 zig-for

If you didn’t already, worth putting comments why each item is there in the black list Sent from my iPhoneOn Jun 28, 2023, at 8:41 AM, AustinSumigray @.> wrote: Solved that glitch, so now all the remaining blacklist items have a purpose. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>

Added.

Jun 29 '23 19:06 AustinSumigray

Jul 22 '23 01:07 ThePhar

Bump. It would be neat if this wasn't lost.

Aug 11 '23 05:08 zig-for

Bump :(

Mar 26 '24 03:03 zig-for

This PR seems sad and abandoned

But also, I don't know what's going on here, and apart from a tentative approval from the world maintainer, I don't have anything to go off of

If you guys test this PR or people who understand more about rom clients review it, I will absolutely be happy to push this through

May 10 '24 07:05 NewSoupVi

Zig is no longer actively maintaining LADX.

I'm still willing to merge LADX PRs, but only with a larger volume of peer reviews.

Jun 21 '24 16:06 NewSoupVi