Archipelago
Archipelago copied to clipboard
ArchipelagoMW
Core: Rework accessibility
Please format your title with what portion of the project this pull request is targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
Renamed "locations" accessibility to "full" - not particularly attached to this if we want it to stay the old name, but I figured a breaking change here would be more noticeable for users. Added subclass of Accessibility - ItemsAccessibility - that adds items accessibility and has it as the default. Have LTTP and SMZ3 use ItemsAccessibility since they use it for stuff.
How was this tested?
Ran the tests and generated a few seeds with and without debug
If this makes graphical changes, please attach screenshots.
Putting this into draft until #993 gets merged as that'll make this cleaner.
Kono approved, I'm in favor*, Berserker didn't disapprove. Can we resolve the conflicts and merge?
* Since upstream SoE only has what is equivalent to "Full" and "Minimal", and for a lot of other games it's probably also more confusing if location and item is effectively the same.
Has anyone thoroughly tested the new version with aliases?
Also I feel like adding merge conflicts and swapping the labels forth and back without actually reviewing it when updated does not help.
I went through every instance of "accessibility" and the only thing I saw that's missed in this PR is CV64 allowing self-locking items but not having items accessibility anymore.
