[Pokemon] Fixes and updates

[Alchav]

trafficstars

What is this fixing or adding?

Fixes logic bugs reported by j_im Fixes to account for 21 byte seed names when generating on web host Filler item update Number of badges needed to enter Viridian Gym displayed in game when attempting to enter

How was this tested?

Generated games and played to ensure text works and no errors with logic changes. Generated games locally and on webhost to ensure connection would not be rejected due to mismatched seed name

[Alchav]

Until a client is available with these changes, no one will be able to play Pokemon R/B on any game generated on the webhost. However once this PR is merged, no one will be able to play any Pokemon R/B games at all until a client with these changes is available. I know people have been jumping into beta tests for other games to play Pokemon since it's on source now. I'm hoping RCs will be soon and this could be merged soon before the RC

[Berserker66]

So I should hold off on merging this until right before the RC?

[Alchav]

I suppose it depends on how long that would be from now. If it's going to be a while, I could just build source and distribute it for pokemon players after this is merged

[Alchav]

The bug present in the earlier beta test appears to be fixed. I believe in fixing the stray commit I overwrote the base patches with earlier versions which did not match with the rom address pointers.

[Alchav]

Since I have released a Pokemon Client off this branch as it is, I'm going to recommend merging it now so that my released client works on other current-source beta test games