Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

Bug: `create_playthrough` is not deterministic

Open toasterparty opened this issue 2 years ago • 0 comments

What happened?

While debugging an issue with my in-dev world, I noticed create_playthrough behaves slightly differently on concurrent runs with the same seed number. In extreme cases, some runs return exceptions while others do not, making it difficulty to consistently debug problems.

I'm no python expert, but I recall that iterating over a set is not deterministic:

        sphere = set(filter(state.can_reach, required_locations))

        for location in sphere:
            state.collect(location.item, True, location)

What were the expected results?

create_playthrough should either always throw an error or always succeed on successive runs with the same input seed

Software

Local generation

toasterparty avatar Sep 12 '22 05:09 toasterparty