ArchBlood

Results 305 comments of ArchBlood

@marc-farre here is my final judgement about this issue, the Cache class doesn't fully comply with PSR-16 due to the following; ## 1. Return Type of `get` Method - **Issue**:...

https://github.com/serbanghita/Mobile-Detect/issues/978#issuecomment-2600584642 will fix the issue, but it can always be improved for backwards compatibility which is what I think was the intent of the current implementation?

> @ArchBlood thank you so much about the details, I will provide a patch asap. I'd need a bit of help with reviewing the final PR, do you mind If...

@gevorgmansuryan I noticed just now after running some tests that the following error can happen if topics do not have a proper container from either the space or user; ```logs...

The issue here is the following; https://github.com/humhub/humhub/blob/38025387c729045208385d9921a59c67799bf3fe/protected/humhub/modules/notification/views/user/notification.php#L34-L38 It should be something like this for it to work; ```php ``` Then it will match the following but only work for the...

> [@ArchBlood](https://github.com/ArchBlood) I dont have in mind to display a warning when user clicks on "Reset to Default" I have in mind to display a warning when user clicks on...

Looking at the JS there is potential issue, it only updates the auth link URL when clicked, but doesn't account for changes to the "Remember Me" checkbox after the initial...

> [@ArchBlood](https://github.com/ArchBlood) Sorry, I don't fully understand. Isn't it enough to append the status of the Remember Me checkbox when clicking on the Auth URL? Maybe it is just me...

> While I agree the number should be the same, shouldn't the correct result be 1 user? > > E.g. I'm using a bunch of users for testing and automation....

> Thanks for the suggestion! > > I'm a bit unsure here, are there examples from other projects of how this is used? e.g. Yii2/3 I'm not sure here when...