mods
mods copied to clipboard
Arch666Angel
Gate usage of the infinite-gem-ore resource
Definition of the infinite-gem-ore resource is gated on the condition that the bobmods-ores-enablegemsore setting is on.
Usage of the resource, in lieu of check for existence of the resource, should use a similar gate.
This fixes issue #767.
Oddly, I don't actually recall not having gems at all with bobs. That may actually be something we would rather force on and hide the setting.
Sure; I'm not actually sure which is the more appropriate fix - this just makes the logic consistent in the two related places and gets rid of the error experienced in log output.
On Tue, Mar 29, 2022, 10:02 PM Pezzawinkle @.***> wrote:
Oddly, I don't actually recall not having gems at all with bobs. That may actually be something we would rather force on and hide the setting.
— Reply to this email directly, view it on GitHub https://github.com/Arch666Angel/mods/pull/768#issuecomment-1082571381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN53TCAGKVSUA775OVHJXODVCO74DANCNFSM5PPLK4MQ . You are receiving this because you authored the thread.Message ID: @.***>
Ill take a look at this with Kiwi (working on bobs side of things), but it does look like something is not functional
I'd be happy to help test whatever you come up with. The reproduction is pretty simple.
On Tue, Mar 29, 2022, 10:16 PM Pezzawinkle @.***> wrote:
Ill take a look at this with Kiwi (working on bobs side of things), but it does look like something is not functional
— Reply to this email directly, view it on GitHub https://github.com/Arch666Angel/mods/pull/768#issuecomment-1082577544, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN53TCA6WCVDFBOUCWIPUILVCPBP3ANCNFSM5PPLK4MQ . You are receiving this because you authored the thread.Message ID: @.***>
No idea. I just copied the only other logic I found defining the resource this was depending on.
On Tue, Mar 29, 2022, 11:27 PM Pezzawinkle @.***> wrote:
@.**** commented on this pull request.
In angelsinfiniteores/prototypes/generation/bob-options.lua https://github.com/Arch666Angel/mods/pull/768#discussion_r838105152:
@@ -1,15 +1,17 @@ if mods["bobores"] then
- if bobmods.ores.settings.UnsortedGemOre == true then
- bobmods.lib.resource.add_result("infinite-gem-ore", {name="gem-ore"})
- else
- bobmods.lib.resource.add_result("infinite-gem-ore", {name="diamond-ore", probability = bobmods.gems.DiamondRatio})
- bobmods.lib.resource.add_result("infinite-gem-ore", {name="emerald-ore", probability = bobmods.gems.EmeraldRatio})
- bobmods.lib.resource.add_result("infinite-gem-ore", {name="amethyst-ore", probability = bobmods.gems.AmethystRatio})
- bobmods.lib.resource.add_result("infinite-gem-ore", {name="ruby-ore", probability = bobmods.gems.RubyRatio})
- bobmods.lib.resource.add_result("infinite-gem-ore", {name="sapphire-ore", probability = bobmods.gems.SapphireRatio})
- bobmods.lib.resource.add_result("infinite-gem-ore", {name="topaz-ore", probability = bobmods.gems.TopazRatio})
- --remove regular gems
- bobmods.lib.resource.remove_result("infinite-gem-ore", "gem-ore")
- if settings.startup["bobmods-ores-enablegemsore"].value == true then
This setting, has an intermediate which can be changed at the data stage by other mods (like the next line) should be if bobmods.ores.gems.enabled == true then apart from that, this looks reasonable, I'm just working through possibilities where this setting is actually relevant.
— Reply to this email directly, view it on GitHub https://github.com/Arch666Angel/mods/pull/768#pullrequestreview-925504123, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN53TCGBH7RW37DCN5EM3IDVCPJ3ZANCNFSM5PPLK4MQ . You are receiving this because you authored the thread.Message ID: @.***>
