Builders-Utilities icon indicating copy to clipboard operation
Builders-Utilities copied to clipboard

Renovate the build gradle file and transfer the plugin.yml into it

Open TheMeinerLP opened this issue 1 year ago • 3 comments

Overview

This pull requests don't target at a issue.

Problem

It is very difficult to read the original Gradle file because it has some things that make no sense for such a small project

Description

This renovate the build gradle file to improve for other developers the readbility. Also transfer the plugin.yml into it with the gradle plugin of Minecrell thats add the option for plugin.yml generation. In that sense it reduce some small lines of code. Its sorts some content in to more clear order also setup up the Java version 17 and uses the newer options of gradle for it.

Checklist

  • [X] I included all information required in the sections above
  • [X] I tested my changes and approved their functionality
  • [X] I ensured my changes do not break other parts of the code

TheMeinerLP avatar Feb 06 '24 14:02 TheMeinerLP

The code restored is incorrect to the code removed. The toolchain should point to Java 17 as development goal but compile against Java 8 as release goal.

The code removed hasn't been restored correctly, TARGET_JVM_VERSION_ATTRIBUTE is still missing, causing a failure in GH actions.

16436bd (#142) is incorrect still. Instead of restoring the previous removed TARGET_JVM_VERSION_ATTRIBUTE field, you modified another entry irrelevant to the former one.

If TARGET_JVM_VERSION_ATTRIBUTE is not added back in the same spot you removed it from, the build will continue to fail.

NotMyFault avatar Feb 13 '24 16:02 NotMyFault

What is the big difference between TARGET_JVM_VERSION_ATTRIBUTE and the current code?

TheMeinerLP avatar Feb 13 '24 16:02 TheMeinerLP

What is the big difference between TARGET_JVM_VERSION_ATTRIBUTE and the current code?

targetCompatibility and sourceCompatibility represent the javac flags -target release and -source release. TARGET_JVM_VERSION_ATTRIBUTE is an attribute for Gradle.

All three options serve different purposes and don't build upon each other.

NotMyFault avatar Feb 13 '24 16:02 NotMyFault