Add "Item Templates" for the Custom Drops system

[redstonepowder]

I have found that the custom drops requiring you to meticulously insert every detail of an item in question to be mildly inconvenient and would like to propose methods to mitigate this issue.

My solution to this is add a method in which players can save an item as a template into a database. A player would 'register' an item in their mainhand, along with an accompanying ID name. Ex: redstonepowder registers an enchanted diamond sword in their mainhand with the ID 'Nulgath' . We can then simply enter Nulgath in the custom drops config file, like itemid: Nulgath, and skip a large portion of fields needed to add Nulgath to the loot system.

This solution should allow the custom drops feature to be more compatible to custom item plugins overall, with some exceptions. A plugin named AureliumSkills has a similar but ultimately less flexible feature, to the suggested solution.

[redstonepowder]

My apologies, I am not familiar with github, so if I have missed anything of note, please do inform me.

[stumper66]

@redstonepowder Your description is perfect. No guarantees if and when we'll add it but it's on the to-do list now. Thanks for the suggestion.

[redstonepowder]

Attached is an example image of the Aurelium Skills config file for custom drops. Material and Key are used to differentiate between vanilla and custom items respectively.

[lokka30]

@redstonepowder - just to make sure I've understood you correctly, this is what I think you are saying:

• Instead of having to configure each item for each drop, instead, drops should be able to use a template, similar to how the Rules System can use presets to auto-fill information and reduce boilerplate.
• In addition, there should be a command to create custom drop item templates from the item in your hand using a command.

Would I be correct?

[redstonepowder]

Hello, first off, sorry for my abysmal response time, I don't make use of github all that often (nor check my email for that matter). Moving on, you've summed up my thoughts splendidly. Is there any issues with the idea?

[stumper66]

@redstonepowder is this any different than using a drop table then referencing that drop table id elsewhere?

[redstonepowder]

I don't think I understand that question, sorry. Are you saying that there's something similar already in play?

[stumper66]

@redstonepowder look at these sample drops: https://github.com/UltimaOath/LevelledMobs/blob/master/src/main/resources/customdrops_oathedition.yml

[redstonepowder]

I've had a look at it and found that, while useful, it differs from my idea in that it allows for quick inclusions to drop table. Not needing to enter fields one by one for each unique drop, and their respective details, saves a lot of time and effort. You could argue that creating items in-game would be more time consuming, but there are public item generators that can cut down the time for that significantly, more importantly, you wouldn't need to painstakingly write in Custom NBT and UUID's.

[lokka30]

I think this can be implemented in the following way:

• A command will dump the item held in the main hand and format it in a way that can be pasted as a custom drop.
• Each dump will be placed in its own file at plugins/LevelledMobs/item-dumps/. i.e.:
  • plugins/LevelledMobs/item-dumps/lokka30-STONE-2022_11_03
  • plugins/LevelledMobs/item-dumps/lokka30-The_Greatest_Sword-2022_11_03
• The user can simply copy the item dump and edit it as desired, paste it in their custom drops file, all done.

[lokka30]

Squashing this into #423 so that our issue tracker is not so complicated with the arduous amount of tasks we need to do for LM 4.0 😁. Feel free to continue discussing here.