SidebarDiagnostics icon indicating copy to clipboard operation
SidebarDiagnostics copied to clipboard

Published 20 hours ago • verified publisher icon ArcadeRenegade

Implemented SidebarBorderWidth Settings

Open nicolgit opened this issue 3 years ago • 7 comments

Hi guys, I have made customizable the padding size from the settings. This because I have found the default padding too wide for my preferences :-) the benefit is that you can earn valuable pixels on the screen. hope you like it.

I have updated the settings dialog

sidebar the model, and the sidebar.xaml

nicolgit avatar Jan 22 '22 07:01 nicolgit

Hi, thanks for the PR. What is the border width though? I don't think there's a border on the sidebar. Is it the padding?

Also this updates Squirrel which may be a breaking change for the auto update.

ArcadeRenegade avatar Jan 22 '22 07:01 ArcadeRenegade

Yes correct, I mean padding 🤪

nicolgit avatar Jan 22 '22 07:01 nicolgit

I had to upgrade squirrel in order to allow to build, not sure why...

nicolgit avatar Jan 22 '22 07:01 nicolgit

Hi @nicolgit ,

This PR will provide support for negative padding?

lars18th avatar Jan 11 '23 13:01 lars18th

no @lars18th this sets only positive padding. Minimum value is 0

nicolgit avatar Jan 17 '23 07:01 nicolgit

no @lars18th this sets only positive padding. Minimum value is 0

And why not? Obviously, it doesn't have sense to write outside of the window space. However, if you want to reduce the border, then the padding could be negative... until the size of the real border.

Any way. When this patch will be merged?

lars18th avatar Jan 17 '23 11:01 lars18th

Hi @nicolgit ,

Still waiting to merge.

lars18th avatar Nov 05 '23 10:11 lars18th