Andreas Rumpf comments

Results 860 comments of


                                            Andreas Rumpf

Support destructor-based seq/strings

The Nim runtime decided for you and uses a shared heap for seqs. ;-)

not GC-safe

Well usually we say "use a thread variable".

not GC-safe

But that's exactly what asyncHttpServer does, it is single-threaded. I don't understand you.

not GC-safe

Exactly. I consider this question answered.

not GC-safe

``.gcafe`` is inferred for you, ``.threadvar`` cannot.

error installation `Error: 'srcdir' should be: 'srcDir'`

So use ``--styleCheck:hint``.

[RFC] Namespace support in knete

I don't understand this PR. Knete is code duplication and should be refactored. It's also not documented, is it? Do you want to use Knete?

vstyles setAttr not changing displayed VNode

> Seems like the diffing code doesn't look at style changes when deciding to update an element? I'm pretty sure that's what we're doing.

Use a different operator for cstring stringification

> introduce toCstring `toCstring` is too verbose, IMHO. I picked an operator because anything else was too verbose. We should use a different operator but I don't know which one.

verbatimRaw: verbatim without creating a `div`

Why does ``verbatim`` create a ``div`` in the first place?