aqueductcore icon indicating copy to clipboard operation
aqueductcore copied to clipboard

feat: keep page info in url

Open safeamiiir opened this issue 9 months ago • 1 comments

safeamiiir avatar Apr 30 '24 17:04 safeamiiir

Coverage

Coverage Report
FileStmtsMissCoverMissing
aqueductcore/backend
   context.py33488%48–52, 59–60
   main.py19479%21–24, 31
   session.py13469%24–28
aqueductcore/backend/models
   orm.py31197%58
aqueductcore/backend/routers
   files.py88298%165–166
   frontend.py241154%22–33, 37
aqueductcore/backend/routers/graphql
   mutations_schema.py39197%42
   query_schema.py41295%64–66
   router.py11191%15
aqueductcore/backend/routers/graphql/mutations
   experiment_mutations.py24196%30
aqueductcore/backend/routers/graphql/resolvers
   experiment_resolver.py25292%28, 36
   tags_resolver.py25388%14, 44, 46
aqueductcore/backend/services
   experiment.py2203285%82, 111–124, 154, 188, 194, 240, 243, 268, 299, 348, 354, 383, 389, 406, 431, 438, 446, 476–482, 489–493, 505–508
   validators.py33294%41, 46
TOTAL8137091% 

Tests Skipped Failures Errors Time
67 0 :zzz: 0 :x: 0 :fire: 10.400s :stopwatch:

github-actions[bot] avatar Apr 30 '24 17:04 github-actions[bot]

I have no idea what happens here, but one change looks suspicious, title: "" -> title: null

This change is because after using searchParams which relies on page URL that has filter/pagination info. when the field is not available, that'll return null. But I'll give a try to use only one string type in order to keep it cleaner.

safeamiiir avatar May 10 '24 11:05 safeamiiir