llvm-bindings icon indicating copy to clipboard operation
llvm-bindings copied to clipboard

[Feature] Support llvm::Function::addFnAttr

Open dvoytenko opened this issue 3 years ago • 2 comments

This API would be very helpful with optimization hints, such as readonly. More on this: https://llvm.org/docs/LangRef.html#function-attributes

dvoytenko avatar Aug 05 '22 17:08 dvoytenko

OK, I will add this API soon.

BTW, if you need other APIs, please try to list them all at once, so that I don't have to release a version every time I add an API

ApsarasX avatar Aug 06 '22 05:08 ApsarasX

Certainly! Thank you!

dvoytenko avatar Aug 11 '22 20:08 dvoytenko

addParamAttr and addRetAttr would also be nice additions :) Thanks for the great work!

nathsou avatar Oct 09 '22 21:10 nathsou

@dvoytenko @ApsarasX In the meantime, I created a fork to add basic support for attributes.

nathsou avatar Oct 12 '22 17:10 nathsou

@dvoytenko @ApsarasX In the meantime, I created a fork to add basic support for attributes.

Good job!

Looking forward to your PR.

ApsarasX avatar Oct 13 '22 08:10 ApsarasX

Awesome! Looking forward to PR as well.

dvoytenko avatar Oct 14 '22 15:10 dvoytenko