XKit-Rewritten icon indicating copy to clipboard operation
XKit-Rewritten copied to clipboard

Quick Reblog: Add dialog height option for Quick Tags Integration.

Open alleycatboy opened this issue 2 years ago • 5 comments

Description

This adds an option in Quick Reblog's preferences to increase or decrease the height of the Quick Tags Integration dialog.

This addresses the issue raised in #867.

It parses the the preference from Quick Reblog and sets it as a CSS variable in quickTagsList component. This makes it available on every subsequent render of the Quick Reblog popup dialog without having to check every single time.

The variable changes the height of the dialog from 1 to 20 units, each unit being the height of the button which is the same height as each tag element.

Default (4): default size

Size 10: size 10

Size 1: size 1

Testing steps

To test, go to the Quick Reblog preferences and set a height different than the default of 4. The change should be reflected immediately.

alleycatboy avatar Dec 30 '22 21:12 alleycatboy

This is lovely, but would it be possible to also provide an "expand to fit" option? Say, if the config variable is set to 0, it acts as if set to length(tagBundles).

skircheis avatar May 08 '23 09:05 skircheis

That's pretty much equivalent to removing the maximum value from this PR and the user setting an extremely high number, which may be simpler.

marcustyphoon avatar May 08 '23 20:05 marcustyphoon

Would that also shrink the list if length(tagBundles) < N? Expand to fit, but no more. If so, sure.

skircheis avatar May 10 '23 12:05 skircheis

Yep! That's what it does currently.

marcustyphoon avatar May 10 '23 19:05 marcustyphoon

Oh, I have had so many bundles for so long I don't recall ever seeing that. Then ignore me being silly, if there's no limit and I can just set it to 813 or whatever that's great.

skircheis avatar May 10 '23 19:05 skircheis