XKit-Rewritten icon indicating copy to clipboard operation
XKit-Rewritten copied to clipboard

TimeFormat: Fix reply timestamps that are links

Open marcustyphoon opened this issue 9 months ago • 2 comments

Description

This fixes the layout improvements added in #1110 and an erroneous lack of underline beneath the relative part of the formatted time when hovered in reply timestamps that are links (currently unreleased/in-testing Tumblr code).

Testing steps

  • Enable the "append relative time" option in TimeFormat and find a reply with a relatively long blog name (such as https://www.tumblr.com/once-more-with-gravitas/778774885212225536/ah-dangit).
  • Confirm that reply timestamps stay as a single line with and without the relevant feature flag.
  • Confirm that reply timestamps are underlined consistently when hovered with the relevant feature flag.

marcustyphoon avatar Mar 23 '25 06:03 marcustyphoon

The on-hover underline offset is weird for me in Firefox; it gets cut off by capital letters:

image

I think we should be applying our own underline, with an offset. Also, let's override back to cursor: pointer; for these...

I'll self-assign this and play with it sometime.

AprilSylph avatar Mar 30 '25 19:03 AprilSylph

That is... very strange-looking. Huh.

marcustyphoon avatar Mar 30 '25 19:03 marcustyphoon

All fixed up, I think:

Screenshot 2025-06-10 at 16-55-52 Tumblr

AprilSylph avatar Jun 10 '25 15:06 AprilSylph

Firefox:

  • [x] middot spacing looks fine in post headers, replies, and likes
  • [x] cursor is pointer in replies
  • [x] cursor is help in post headers (dom modified to test; currently there's an <a> covering them) and likes
  • [x] reply hover underlines look correct

Chrome:

  • [x] middot spacing looks fine in post headers, replies, and likes
  • [x] cursor is pointer in replies
  • [x] cursor is help in post headers (dom modified to test; currently there's an <a> covering them) and likes
  • [x] reply hover underlines look correct

Safari 17.6:

  • [x] middot spacing looks fine in post headers, replies, and likes
  • [x] cursor is pointer in replies
  • [ ] cursor is help in post headers (dom modified to test; currently there's an <a> covering them) and likes
  • [x] reply hover underlines look correct

Safari help cursor is not a regression, as this was apparently the case before. Presumably a Safari bug with setting cursor on a pseudo; I didn't look into it.

marcustyphoon avatar Jun 10 '25 19:06 marcustyphoon