XKit-Rewritten icon indicating copy to clipboard operation
XKit-Rewritten copied to clipboard

Mass Deleter: Improve drafts fetching

Open marcustyphoon opened this issue 1 year ago • 1 comments

Description

This improves the fetch speed of Mass Deleter's delete-drafts mode and displays an incrementing counter based on the total number of posts fetched as well as the number that meet the date range criteria.

See #1595. Resolves #1596.

Do you think we should also include the before parameter on every api fetch that could plausibly be updated to support it, even when the endpoint doesn't?

Testing steps

marcustyphoon avatar Aug 28 '24 22:08 marcustyphoon

  • [x] address #1610

marcustyphoon avatar Sep 09 '24 09:09 marcustyphoon

Do you think we should also include the before parameter on every api fetch that could plausibly be updated to support it, even when the endpoint doesn't?

nah, that seems silly

AprilSylph avatar Feb 16 '25 20:02 AprilSylph

Do you think we should also include the before parameter on every api fetch that could plausibly be updated to support it, even when the endpoint doesn't?

Fun fact: I don't remember what this refers to or means even a little bit.

marcustyphoon avatar Feb 16 '25 20:02 marcustyphoon

Do you think we should also include the before parameter on every api fetch that could plausibly be updated to support it, even when the endpoint doesn't?

Fun fact: I don't remember what this refers to or means even a little bit.

at the time, we had recently updated Mass Privater to use the before query parameter in its API URL to avoid fetching all posts on the target blog and just filtering to before the input timestamp. now we start fetching posts on the target blog starting at the input timestamp instead. but, this parameter only exists for published posts on a blog, not drafts or queue--you were proposing we add it here under the assumption it would be a no-op, just in case tumblr supports it in the future.

AprilSylph avatar Feb 16 '25 20:02 AprilSylph