Slight inconsistency with sidebar on settings pages (minor)

[marcustyphoon]

Platform

MacOS 13.2.1 arm64

Browser

Chrome 114.0.5735.106

Addon version

dev

Details

Today on The World's Most Inconsequential Bugs:

Navigating to https://www.tumblr.com/domains breaks the check added in #993, as it is a settings page but doesn't have settings in its URL. This results in the sidebar items for Limit Checker and Tag Replacer being displayed there and on any settings page one navigates to from there, which is inconsistent vs. navigating to settings any other way.

(I actually noticed this by clicking the "get a domain" navigation item in the feature preview, which links to /domains instead of /settings/domains.)

Easy fix of just adding /domains to the check, I assume.

[marcustyphoon]

Could also be solved declaratively via something like div:has(> ul > li > a[href^="/settings"]) + #xkit-sidebar { display: none }.