apriltag_ros icon indicating copy to clipboard operation
apriltag_ros copied to clipboard

Published 20 hours ago • verified publisher icon AprilRobotics

adding 36h9

Open davelkan-zz opened this issue 6 years ago • 9 comments

Adding the 36h9 tag family

davelkan-zz avatar May 10 '18 22:05 davelkan-zz

@dmalyuta

davelkan-zz avatar May 14 '18 17:05 davelkan-zz

We are about to upgrade to AprilTag 3 which does not ship with the 36h9 family - is this still of interest?

wxmerkt avatar Mar 07 '19 11:03 wxmerkt

Yes I would still like access to this tag family

davelkan-zz avatar Mar 07 '19 15:03 davelkan-zz

Would you consider trying to upstream it to https://github.com/AprilRobotics/apriltags/?

wxmerkt avatar Mar 07 '19 15:03 wxmerkt

kk

davelkan-zz avatar Mar 07 '19 15:03 davelkan-zz

https://github.com/AprilRobotics/apriltags/pull/12

davelkan-zz avatar Mar 07 '19 16:03 davelkan-zz

@wxmerkt thoughts on including 36h9? upstream said no

davelkan-zz avatar Mar 11 '19 15:03 davelkan-zz

I saw the upstream comment. We are about to remove the forked code and build on the officially released apriltag (once https://github.com/AprilRobotics/apriltags/pull/11 is merged and released via the ROS buildfarm as debians) - happy to integrate 36h9 if it can be done in a build step as part of the ROS module rather than the library?

wxmerkt avatar Mar 11 '19 15:03 wxmerkt

Thanks @wxmerkt, looks like that's a valid option.

paulbovbel avatar Mar 11 '19 15:03 paulbovbel

Hi @davelkan-zz, If this is still of interest and you can re-base it on / make it work with the current master, happy to include it

wxmerkt avatar Nov 21 '22 16:11 wxmerkt

Closing as inactive. Happy to reconsider once made compatible with the latest master branch

wxmerkt avatar Mar 27 '23 17:03 wxmerkt