apriltag icon indicating copy to clipboard operation
apriltag copied to clipboard

Resolve warnings; signed unsigned comparison

Open csaba-luxonis opened this issue 3 years ago • 1 comments

Resolved comparison between signed and unsigned.

csaba-luxonis avatar Jul 06 '21 00:07 csaba-luxonis

Instead of converting the upper bounds of the loop to a signed "int", I would prefer if you convert the running variable to an unsigned int (size_t for memory sizes) to better indicate that this running variable is a positive index.

christian-rauch avatar Nov 15 '21 12:11 christian-rauch

This is now superseded by PR https://github.com/AprilRobotics/apriltag/pull/309 where this and other warnings are fixed and reported as errors to make sure that they do not appear again.

christian-rauch avatar Jan 19 '24 13:01 christian-rauch