shiny.semantic icon indicating copy to clipboard operation
shiny.semantic copied to clipboard

show warning if default shiny page fct is used

Open rabiibouhestine opened this issue 4 years ago • 1 comments

Short description (with a reference to an issue).

closes #328

When using a default shiny page fct (fluidPage,..), a warning message now informs the user that there will be display issues.

DoD

  • [ ] Major project work has a corresponding task. If there’s no task for what you are doing, create it. Each task needs to be well defined and described.

  • [ ] Change has been tested (manually or with automated tests), everything runs correctly and works as expected. No existing functionality is broken.

  • [ ] No new error or warning messages are introduced.

  • [ ] All interaction with a semantic functions, examples and docs are written from the perspective of the person using or receiving it. They are understandable and helpful to this person.

  • [ ] If the change affects code or repo sctructure, README, documentation and code comments should be updated.

  • [ ] All code has been peer-reviewed before merging into any main branch.

  • [ ] All changes have been merged into the main branch we use for development (develop).

  • [ ] Continuous integration checks (linter, unit tests) are configured and passed.

  • [ ] Unit tests added for all new or changed logic.

  • [ ] All task requirements satisfied. The reviewer is responsible to verify each aspect of the task.

  • [ ] Any added or touched code follows our style-guide.

rabiibouhestine avatar May 12 '21 12:05 rabiibouhestine

@rabiibouhestine I try this to test:

library(shiny)
library(shiny.semantic)

ui <- fluidPage(
  textInput("input_id", "My text")
)

server <- function(input, output, session) {
}

shinyApp(ui = ui, server = server)

But I don't get any warning message, can you check this?

I think it's also worth adding some unit tests.

aniaskrzydlo avatar Aug 23 '21 14:08 aniaskrzydlo