[Bug]:

[wincowgerDEV]

Guidelines

• [X] I agree to follow this project's Contributing Guidelines.

Project Version

0.1.6

Platform and OS Version

Windows 11

Existing Issues

No response

What happened?

Logical value with NA produces Error when trying to validate cols with not_na. Reproducible example below.

Error in dplyr::group_by(): ! Must group by variables found in .data. Column assertion.id is not found. Column description is not found.The reproducible

Steps to reproduce

test <- data.frame(V1 = "c", V2 = NA)

report <- data_validation_report()

validate(test, description = "Tests") %>% validate_cols(description = "There should not be any NAs or other missing values in columns", not_na, V1:V2) %>% #validate_cols(description = "Event ID can only be Low, High, or Flood", in_set(c("Low", "High", "Flood")), event_id) %>% add_results(report)

Expected behavior

I expected it to not validate column V2

Attachments

No response

Screenshots or Videos

No response

Additional Information

No response

[mariadrywien]

Hi @wincowgerDEV! We've investigated this bug and it turned out to be an issue in the assertr package, on which data.validator depends. We hope it will be solved shortly. You can check its status here.

[wincowgerDEV]

Thanks for the update! Will follow.

On Fri, Oct 21, 2022 at 2:54 PM mariadrywien @.***> wrote:

Hi @wincowgerDEV https://github.com/wincowgerDEV! We've investigated this bug and it turned out to be an issue in the assertr package, on which data.validator depends. We hope it will be solved shortly. You can check its status here https://github.com/ropensci/assertr/issues/94.

— Reply to this email directly, view it on GitHub https://github.com/Appsilon/data.validator/issues/33#issuecomment-1286923910, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJU4J62MLTEB3TQWVSNTWEKG7NANCNFSM55ULMOCA . You are receiving this because you were mentioned.Message ID: @.***>

--

´¯·.¸¸.·´¯·.´¯·.¸¸.·´¯ツ ------------------------------

*Win Cowger, PhD * Pronouns: he/him Research Scientist Moore Institute for Plastic Pollution Research

Contact Info

515-298-3869 | @.*** | @Win_OpenData https://twitter.com/Win_OpenData

Websites Personal Website: www.wincowger.com Currently Employed: https://mooreplasticresearch.org/ Alumni Of: https://www.thegraylab.org/ Project Websites: www.openspecy.org Research Gate: https://www.researchgate.net/profile/Win-Cowger Github: https://github.com/wincowgerDEV OSF: https://osf.io/kxeh5/

[mariadrywien]

@jakubnowicki I saw that assertr has been upgraded to 3.0.0 and this issue was fixed in this release. If you have a moment, please check whether upgrading to assertr=3.0.0 solves the problem in data.validator 🙂

[jakubnowicki]

@wincowgerDEV assertr version 3.0.0 didn't solve this bug, but the current development version available on GitHub finally fixes it.

[wincowgerDEV]

Awesome! Thanks for the update. Looking forward to checking it out.

On Thu, May 4, 2023, 3:22 AM Jakub Nowicki @.***> wrote:

@wincowgerDEV https://github.com/wincowgerDEV assertr version 3.0.0 didn't solve this bug, but the current development version available on GitHub https://github.com/ropensci/assertr finally fixes it.

— Reply to this email directly, view it on GitHub https://github.com/Appsilon/data.validator/issues/33#issuecomment-1534493652, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMUJUZRMYOXBSRWDGQX3DLXEN7N7ANCNFSM55ULMOCA . You are receiving this because you were mentioned.Message ID: @.***>

[jakubnowicki]

[email protected] with the fix is on CRAN, closing the issue.