appsflyer-react-native-plugin
appsflyer-react-native-plugin copied to clipboard
chore(android): add support for AGP 8
Change to support AGP 8 as mentioned here: https://github.com/react-native-community/discussions-and-proposals/issues/671
This does not remove package attribute from AndroidManifest to not lose compatibility with AGP < 8 (React Native < 0.71 versions).
I don't think it's worth maintaining logic to remove that attribute contitionally since it will only cause a warning to users on AGP 8 and above.
See Kudo's comment on AGP 8 issues with BuildConfig and setting JVM versions.
https://github.com/react-native-community/discussions-and-proposals/issues/671 this issue says that after adding namespace, you should delete package definition from AndroidManifest.xml file.
Is this change not necessary?
react-native-community/discussions-and-proposals#671 this issue says that after adding namespace, you should delete package definition from
AndroidManifest.xmlfile. Is this change not necessary?
yup that change is also necessary