appsflyer-react-native-plugin icon indicating copy to clipboard operation
appsflyer-react-native-plugin copied to clipboard

chore(android): add support for AGP 8

Open AndreiCalazans opened this issue 2 years ago • 2 comments

Change to support AGP 8 as mentioned here: https://github.com/react-native-community/discussions-and-proposals/issues/671

This does not remove package attribute from AndroidManifest to not lose compatibility with AGP < 8 (React Native < 0.71 versions).

I don't think it's worth maintaining logic to remove that attribute contitionally since it will only cause a warning to users on AGP 8 and above.

See Kudo's comment on AGP 8 issues with BuildConfig and setting JVM versions.

AndreiCalazans avatar Sep 06 '23 16:09 AndreiCalazans

https://github.com/react-native-community/discussions-and-proposals/issues/671 this issue says that after adding namespace, you should delete package definition from AndroidManifest.xml file. Is this change not necessary?

lafest avatar Oct 06 '23 00:10 lafest

react-native-community/discussions-and-proposals#671 this issue says that after adding namespace, you should delete package definition from AndroidManifest.xml file. Is this change not necessary?

yup that change is also necessary

felipecsl avatar Nov 17 '23 18:11 felipecsl